[
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928668#comment-15928668
]
ASF GitHub Bot commented on NIFI-3380:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1585#discussion_r106506092
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/reporting/AbstractReportingTaskNode.java
---
@@ -125,7 +141,12 @@ public void setSchedulingPeriod(final String
schedulingPeriod) {
@Override
public ReportingTask getReportingTask() {
- return reportingTask;
+ return reportingTaskRef.get().getReportingTask();
+ }
+
+ @Override
+ public void setReportingTask(final LoggableComponent<ReportingTask>
reportingTask) {
+ this.reportingTaskRef.set(new ReportingTaskDetails(reportingTask));
--- End diff --
We should make sure here that the Reporting Task is stopped, similar to
Processors. And should also ensure that Controller Services are disabled when
calling setControllerService.
> Multiple Versions of the Same Component
> ---------------------------------------
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Bryan Bende
> Assignee: Bryan Bende
> Fix For: 1.2.0
>
> Attachments: nifi-example-processors-nar-1.0.nar,
> nifi-example-processors-nar-2.0.nar, nifi-example-service-api-nar-1.0.nar,
> nifi-example-service-api-nar-2.0.nar, nifi-example-service-nar-1.0.nar,
> nifi-example-service-nar-1.1.nar, nifi-example-service-nar-2.0.nar
>
>
> This ticket is to track the work for supporting multiple versions of the same
> component within NiFi. The overall design for this feature is described in
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be
> created to track enhancements for the NAR Maven Plugin.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
