GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/1601
NIFI-3361 Upgrade Jetty version to 9.4.2
Some of the existing tests for `GetHTTP` and `PostHTTP` needed to be
updated or ignored; this is not because of any change to these processors, but
rather the existing Jetty test server which was used to validate them.
Jetty 9.4.0+ only supports TLSv1.2, so we should be very clear in the
release notes for NiFi 1.2.0 that TLSv1/1.1 are no longer supported.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-3361
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1601.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1601
----
commit 53cee70694f4b62cd634ab46534e7b8e47893cf4
Author: Matt Gilman <[email protected]>
Date: 2017-03-15T17:06:26Z
NIFI-3361:
- Upgrading to the latest Jetty version.
commit 6dbb80cfd55134e82e6a73508d0ded357adee003
Author: Andy LoPresto <[email protected]>
Date: 2017-03-16T03:19:46Z
NIFI-3361 Refactored TestGetHTTPGroovy for componentization & customization
of tests.
Ignored some TestGetHTTPGroovy tests because they cannot connect to a Jetty
server running TLSv1 or TLSv1.1 (the new version of Jetty only supports
TLSv1.2+). The tests are still valuable to demonstrate GetHTTP's capacity to
connect to various TLS protocols, and should not be removed unless necessary.
commit ce4c9857ce8c98f630af21b233f6f2b2230ec731
Author: Andy LoPresto <[email protected]>
Date: 2017-03-16T03:26:27Z
NIFI-3361 Refactored TestPostHTTPGroovy for componentization &
customization of tests.
Ignored some TestPostHTTPGroovy tests because they cannot connect to a
Jetty server running TLSv1 or TLSv1.1 (the new version of Jetty only supports
TLSv1.2+). The tests are still valuable to demonstrate PostHTTP's capacity to
connect to various TLS protocols, and should not be removed unless necessary.
commit 015acf8562e714042b85f70897450bf30e9d148d
Author: Andy LoPresto <[email protected]>
Date: 2017-03-16T04:52:01Z
NIFI-3361 Restored one of the TestGetHTTPGroovy unit tests (GetHTTP vs.
TLSv1/1.1/1.2) by connecting to https://nifi.apache.org which still supports
all three protocol versions (and uses JVM cacerts as truststore).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
