[
https://issues.apache.org/jira/browse/NIFI-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930713#comment-15930713
]
ASF GitHub Bot commented on NIFI-2481:
--------------------------------------
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/1603
NIFI-2481 improved content repo archive description in Admin Guide
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mosermw/nifi nifi-2481
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1603.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1603
----
commit 1e83e605e00912f27551f8096ec0094b86aa159d
Author: Mike Moser <[email protected]>
Date: 2017-03-17T20:53:52Z
NIFI-2481 improved content repo archive description in Admin Guide
----
> FileSystemRepository: maxArchiveBytes calculated incorrectly
> ------------------------------------------------------------
>
> Key: NIFI-2481
> URL: https://issues.apache.org/jira/browse/NIFI-2481
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Brandon DeVries
> Assignee: Michael Moser
> Priority: Minor
>
> It appears as though the calculation of maxArchiveBytes in
> FileSystemRepository.java might be backwards. The line in question\[1\] is:
> {code}
> final long maxArchiveBytes = (long) (capacity * (1D - (maxArchiveRatio -
> 0.02)));
> {code}
> if you say capacity = 1000, then you get the following:
> maxArchiveRatio = .1 ==> maxArchiveBytes = 920
> maxArchiveRatio = .5 ==> maxArchiveBytes = 520
> maxArchiveRatio = .9 ==> maxArchiveBytes = 120
> In other words, as you increase the
> nifi.content.repository.archive.max.usage.percentage, you would be decreasing
> the bytes allowed for archiving...
> \[1\]
> https://github.com/apache/nifi/blob/rel/nifi-0.7.0/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/FileSystemRepository.java#L189
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
