Github user bbende commented on the issue:

    https://github.com/apache/nifi/pull/1585
  
    @markap14 The PR has been updated to address your comments and to fix a 
couple of other issues that were identified, also rebased against master as of 
yesterday evening.
    
    Here are the changes since your last review:
    
    - 
https://github.com/apache/nifi/pull/1585/commits/fadf43d7ccc755b5a5e3b52692e6b8f814afb657
 (synchronization in node classes)
    - 
https://github.com/apache/nifi/pull/1585/commits/b1ed76c2bc4ec3a639d360017fe899a8fd5777a7
 (CS bundled with API + restructure Hive NAR)
    - 
https://github.com/apache/nifi/pull/1585/commits/6b2ac1fb77ee08ce4b183e3b78c7c178c38256ae
 (missing components in fingerprinting)
    - 
https://github.com/apache/nifi/pull/1585/commits/8988cd9a88ab528bbbb25c07260b17b5179c5886
 (checkstyles and failing tests)
    
    I'm going to continue testing today, but let me know if there is anything 
else to address.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to