[
https://issues.apache.org/jira/browse/NIFI-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945854#comment-15945854
]
ASF GitHub Bot commented on NIFI-3630:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1632
NIFI-3630: Use a BufferedOutputStream when checkpointing FlowFile Rep…
…ository
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3630
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1632.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1632
----
commit 84d4193010b5784ecc6be8d6578292bfbfe2b05e
Author: Mark Payne <[email protected]>
Date: 2017-03-28T20:11:25Z
NIFI-3630: Use a BufferedOutputStream when checkpointing FlowFile Repository
----
> FlowFileRepository / WriteAhead Log should use a BufferedOutputStream when
> checkpointing
> ----------------------------------------------------------------------------------------
>
> Key: NIFI-3630
> URL: https://issues.apache.org/jira/browse/NIFI-3630
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 1.2.0
>
>
> Currently, calls to MinimalLockingWirteAheadLog's checkpoint() method create
> a FileOutputStream, then wrap that in a DataOutputStream and start writing to
> the DataOutputStream, passing that along the SerDe as well. The
> FileOutputStream that it writes to should be wrapped in a
> BufferedOutputStream, as each call to checkpoint() is very taxing on the file
> system currently.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
