GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1634
NIFI-3657: Fix HTTP S2S to use local address.
- Fixed SiteInfoProvider and HttpClient to use specified local address with
its SiteToSiteRestApiClient
- Removed setupRequestConfig method call from connection and read timeout
setter methods at SiteToSiteRestApiClient, because it created config object
before local address was set
- Null clear StandardRemoteProcessGroup localAddress when user clears Local
Network Interface
Confirmed both RAW and HTTP S2S use specified network interface for all S2S
related requests. I used `netstat` command to observe that the expected local
address is used:
```bash
# Show connections towards 11200 or 11201
# 192.168.99.1 is the address for the specified nic in my env,
# and it can be confirmed that no other address is used for connections to
remote NiFi instance.
$ netstat -an |egrep -e '.1120[01]\s+[ETL]'
tcp4 0 0 192.168.99.1.55953 192.168.11.1.11201
ESTABLISHED
tcp4 0 0 192.168.99.1.55952 192.168.11.1.11201
ESTABLISHED
tcp4 0 0 192.168.99.1.57827 192.168.2.101.11200 TIME_WAIT
tcp4 0 0 192.168.99.1.57868 192.168.2.101.11200 TIME_WAIT
# If no Local Network Interface is specified, S2S client used the default
address.
$ netstat -an |egrep -e '.1120[01]\s+[ETL]'
tcp4 0 0 192.168.2.101.58041 192.168.2.101.11201
ESTABLISHED
tcp4 0 0 192.168.2.101.58040 192.168.2.101.11201
ESTABLISHED
tcp4 0 0 192.168.2.101.58096 192.168.2.101.11200 TIME_WAIT
tcp4 0 0 192.168.2.101.58135 192.168.2.101.11200 TIME_WAIT
```
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-3657
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1634.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1634
----
commit 2dda3798ca2861ce6c8c56fd1e52f1224a30af78
Author: Koji Kawamura <[email protected]>
Date: 2017-03-29T06:18:57Z
NIFI-3657: Fix HTTP S2S to use local address.
- Fixed SiteInfoProvider and HttpClient to use specified local address with
its SiteToSiteRestApiClient
- Removed setupRequestConfig method call from connection and read timeout
setter methods at SiteToSiteRestApiClient, because it created config object
before local address was set
- Null clear StandardRemoteProcessGroup localAddress when user clears Local
Network Interface
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
