[
https://issues.apache.org/jira/browse/NIFI-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950356#comment-15950356
]
ASF GitHub Bot commented on NIFI-3440:
--------------------------------------
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/1638
NIFI-3440 fixing tests not written for windows to not run on windows
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-3440
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1638.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1638
----
commit 6ec13af8dc5fa2f333c3f80e922684e0130ac550
Author: joewitt <[email protected]>
Date: 2017-03-31T05:38:37Z
NIFI-3440 fixing tests not written for windows to not run on windows
----
> Test failures on Win10 for recent test changes
> ----------------------------------------------
>
> Key: NIFI-3440
> URL: https://issues.apache.org/jira/browse/NIFI-3440
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.2.0
> Environment: Windows10
> Reporter: Joseph Witt
> Fix For: 1.2.0
>
> Attachments:
> 0001-NIFI-3440-Added-retry-logic-when-trying-to-delete-ne.patch,
> 0001-NIFI-3440-Use-File-I-O-API-instead-of-NIO-API-for-de.patch,
> NIFI-3340_ignore_on_windows.patch, NIFI-3340_ignore_on_windows.patch
>
>
> Running org.apache.nifi.controller.repository.io.TestLimitedInputStream
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in
> org.apache.nifi.controller.repository.io.Test
> LimitedInputStream
> Running org.apache.nifi.controller.repository.TestFileSystemRepository
> Tests run: 31, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 28.698 sec
> <<< FAILURE! - in org.apache.nifi.controller
> .repository.TestFileSystemRepository
> testReadWithContentArchived(org.apache.nifi.controller.repository.TestFileSystemRepository)
> Time elapsed: 0.596 sec <<
> < ERROR!
> java.nio.file.FileSystemException:
> C:\Users\nifi\nifi.git\nifi-nar-bundles\nifi-framework-bundle\nifi-framework\nifi-fra
> mework-core\target\content_repository\1\1486264479123-1: The process cannot
> access the file because it is being used by
> another process.
> at
> sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:86)
> at
> sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97)
> at
> sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102)
> at
> sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:269)
> at
> sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(AbstractFileSystemProvider.java:108)
> at java.nio.file.Files.deleteIfExists(Files.java:1165)
> at
> org.apache.nifi.controller.repository.TestFileSystemRepository.testReadWithContentArchived(TestFileSystemRepo
> sitory.java:408)
> testReadWithNoContentArchived(org.apache.nifi.controller.repository.TestFileSystemRepository)
> Time elapsed: 0.621 sec
> <<< ERROR!
> java.lang.Exception: Unexpected exception,
> expected<org.apache.nifi.controller.repository.ContentNotFoundException> but
> was<java.nio.file.FileSystemException>
> at
> sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:86)
> at
> sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97)
> at
> sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102)
> at
> sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:269)
> at
> sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(AbstractFileSystemProvider.java:108)
> at java.nio.file.Files.deleteIfExists(Files.java:1165)
> at
> org.apache.nifi.controller.repository.TestFileSystemRepository.testReadWithNoContentArchived(TestFileSystemRe
> pository.java:429)
> Running org.apache.nifi.controller.repository.TestRingBufferEventRepository
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.078 sec -
> in org.apache.nifi.controller.repository.Tes
> tRingBufferEventRepository
> Running org.apache.nifi.controller.repository.TestStandardProcessSession
> [~markap14] isnt this something you've addressed before perhaps in another
> test?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
