Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1376
  
    @qfdk Thank you very much for recording and sharing the video. I can see 
how it improves execution time of generated SQL. This enhancement is 
significant for the first execution of GenerateTableFetch processor if there 
are many records to fetch. The performance difference is huge!
    
    For the 2nd time or later, GenerateTableFetch uses 'where' clause using 
'Max value columns' so it will not be a problem after 1st run if the max value 
columns are properly indexed. But if there are so many records inserted or 
updated, between GenerateTableFetch runs, it will have the same issue if we use 
`limit offset`.
    
    I understand how it should work now. Please let me know when you finish 
updating PR. I will review it as soon as possible. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to