[
https://issues.apache.org/jira/browse/NIFI-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951668#comment-15951668
]
ASF GitHub Bot commented on NIFI-3666:
--------------------------------------
GitHub user brosander opened a pull request:
https://github.com/apache/nifi/pull/1641
NIFI-3666 - TlsToolkit using .equals() comparison for parent and root
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] - N/A - If adding new dependencies to the code, are these
dependencies licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] - N/A - If applicable, have you updated the LICENSE file, including
the main LICENSE file under nifi-assembly?
- [X] - N/A - If applicable, have you updated the NOTICE file, including
the main NOTICE file found under nifi-assembly?
- [X] - N/A - If adding new Properties, have you added .displayName in
addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] - N/A - Have you ensured that format looks appropriate for the output
in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brosander/nifi NIFI-3666-tls-toolkit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1641.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1641
----
commit 862e8034353cd5453b15f8cf578c4463da9c2526
Author: Bryan Rosander <[email protected]>
Date: 2017-03-31T17:16:57Z
NIFI-3666 - TlsToolkit using .equals() comparison for parent and root
----
> Skipped tests on windows need to be validated or fixed
> ------------------------------------------------------
>
> Key: NIFI-3666
> URL: https://issues.apache.org/jira/browse/NIFI-3666
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework, Extensions
> Reporter: Joseph Witt
> Priority: Critical
>
> In NIFI-3440 a number of relatively recently created tests were failing on
> windows. These tests were skipped when running on windows to help keep the
> build moving along and to continue to test regressions on older more stable
> tests. However, this approach leaves room for error because we must go
> through each and validate whether it was a bad test that needs to be fixed to
> be more stable/portable OR whether the test exposed a bug in the code and its
> behavior on windows.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
