[
https://issues.apache.org/jira/browse/NIFI-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953061#comment-15953061
]
ASF GitHub Bot commented on NIFI-3668:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1646
NIFI-3668: Fix purging expired replicate requests.
Newly created async response is added before checking map size nor
purging expired ones. If there are already 100 remaining requests,
the added request will not be executed nor removed.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-3668
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1646.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1646
----
commit e6955f01fdc6af73adbfd846b488083ca5ee672a
Author: Koji Kawamura <[email protected]>
Date: 2017-04-03T06:56:21Z
NIFI-3668: Fix purging expired replicate requests.
Newly created async response is added before checking map size nor
purging expired ones. If there are already 100 remaining requests,
the added request will not be executed nor removed.
----
> ThreadPoolRequestReplicator doesn't purge expired requests
> ----------------------------------------------------------
>
> Key: NIFI-3668
> URL: https://issues.apache.org/jira/browse/NIFI-3668
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.2.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
>
> NIFI-3636 has changes the execution order of putting new entry to the
> responseMap and purging expired ones from the same map.
> After NIFI-3636, ThreadPoolRequestReplicator adds new
> StandardAsyncClusterResponse entry into responseMap before checking or
> purging the map. The newly created entry matches with its isComplete()
> method, so it won't be purged even if its expired.
> Then if there's already more than 100 remaining request, the newly created
> request is rejected with "Cannot replicate request {} {} because there are {}
> outstanding HTTP Requests already. Request Counts Per URI = {}" message.
> And the request will not be performed even though its already put into the
> map. As mentioned earlier, these async response initial state is 'completed'
> so it won't be purged and remains in the map forever.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
