Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109740706
  
    --- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
    @@ -682,6 +682,7 @@ bool Site2SiteClientProtocol::receive(std::string 
transactionID,
     
     bool Site2SiteClientProtocol::send(
         std::string transactionID, DataPacket *packet, 
std::shared_ptr<FlowFileRecord> flowFile,
    +   uint8_t *payload, int length,
    --- End diff --
    
    Can payload be embedded into DataPacket, thus  simplifying this function?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to