Github user trkurc commented on the issue:

    https://github.com/apache/nifi/pull/1586
  
    The content of the LICENSE and NOTICE look good. Did you see my comment on 
thinking about renaming to OSUtils. Had you considered that?
    
    Building with the contrib-check profile does not complete (you should be 
able to replicate with `mvn clean install -Pcontrib-check -pl nifi-bootstrap`). 
The javadoc params are missing descriptions, and there are a couple trailing 
whitespaces. 
    
    ```
    [WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[32] 
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty 
description.
    [WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[33] 
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty 
description.
    [WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[35] 
(regexp) RegexpSinglelineJava: Line has trailing whitespace.
    [WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[60] 
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty 
description.
    [WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[61] 
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty 
description.
    [WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[63] 
(regexp) RegexpSinglelineJava: Line has trailing whitespace.
    [WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[88] 
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty 
description.
    [WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[89] 
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty 
description.
    [WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[91] 
(regexp) RegexpSinglelineJava: Line has trailing whitespace.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to