[
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956094#comment-15956094
]
ASF GitHub Bot commented on NIFI-3586:
--------------------------------------
Github user trkurc commented on the issue:
https://github.com/apache/nifi/pull/1586
The content of the LICENSE and NOTICE look good. Did you see my comment on
thinking about renaming to OSUtils. Had you considered that?
Building with the contrib-check profile does not complete (you should be
able to replicate with `mvn clean install -Pcontrib-check -pl nifi-bootstrap`).
The javadoc params are missing descriptions, and there are a couple trailing
whitespaces.
```
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[32]
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty
description.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[33]
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty
description.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[35]
(regexp) RegexpSinglelineJava: Line has trailing whitespace.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[60]
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty
description.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[61]
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty
description.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[63]
(regexp) RegexpSinglelineJava: Line has trailing whitespace.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[88]
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty
description.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[89]
(javadoc) NonEmptyAtclauseDescription: At-clause should have a non-empty
description.
[WARNING] src/main/java/org/apache/nifi/bootstrap/util/OSUtil.java[91]
(regexp) RegexpSinglelineJava: Line has trailing whitespace.
```
> Nifi is not returning PID in Windows
> ------------------------------------
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
> Reporter: Puspendu Banerjee
> Priority: Minor
>
> Nifi PID is unavailable during startup under Windows
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
