[
https://issues.apache.org/jira/browse/NIFI-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958930#comment-15958930
]
ASF GitHub Bot commented on NIFI-3509:
--------------------------------------
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/1651
NIFI-3509 Fixed ID duplication
Fixed the possibility of duplicated MSB part of the component during
template creation
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-3509
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1651.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1651
----
commit 7c74d8ce36f59d09266f8fcb0c78b0fced213085
Author: Oleg Zhurakousky <[email protected]>
Date: 2017-04-06T13:27:25Z
NIFI-3509 Fixed ID duplication
Fixed the possibility of duplicated MSB part of the component during
template creation
----
> Creating templates of copied and pasted PGs can cause issues
> -------------------------------------------------------------
>
> Key: NIFI-3509
> URL: https://issues.apache.org/jira/browse/NIFI-3509
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.1.1
> Reporter: Joseph Percivall
> Assignee: Oleg Zhurakousky
> Priority: Critical
> Attachments: Screen Shot 2017-02-20 at 7.38.49 PM.png, Screen Shot
> 2017-02-20 at 7.53.21 PM.png, Screen Shot 2017-02-20 at 7.53.34 PM.png,
> templatesForNIFI-3509.zip
>
>
> Using the following steps I was able to create a template which instantiates
> with connections from one input port to another input port of another PG. See
> the template here[1].
> See the first attached screenshot for the seed flow. After importing, it
> originally gives an error "Cannot add Connection to Process Group because its
> destination does not belong to this Process Group" and nothing appears to be
> added but after I refresh the canvas parts of the original flow appear
> (screenshot 2 and 3).
> What is most odd, is that there are connections going from the input port
> "input" of pg "test" to the input ports of other PGs. I didn't think that was
> possible.
> The steps I used to create it:
> 1: create a PG "test" with input port "input", UpdateAttribute and output
> port "output". Creating connections between them.
> 2: Go to Parent group and copy "test".
> 3: Go back into "test" and paste.
> 4: Copy and paste "test" multiple times, creating the flow.
> 5: Create a template of the flow
> 6: When using the template, see the issue described.
> The root cause of the issues, I believe, is that the id for the parent group
> starts with "f3ac1eb5-1010-115a" and when I copied and pasted "test" into
> itself it created the "test" pg with an id starting with the same value.
> [1] https://gist.github.com/JPercivall/923519ef09500886c50a8f574f7662ca
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
