Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1652#discussion_r110544779
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVRecordSetWriter.java
---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.csv;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.commons.csv.CSVFormat;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.serialization.DateTimeTextRecordSetWriter;
+import org.apache.nifi.serialization.RecordSetWriter;
+import org.apache.nifi.serialization.RecordSetWriterFactory;
+
+@Tags({"csv", "result", "set", "recordset", "record", "writer",
"serializer", "row", "tsv", "tab", "separated", "delimited"})
+@CapabilityDescription("Writes the contents of a RecordSet as CSV data.
The first line written "
+ + "will be the column names. All subsequent lines will be the values
corresponding to those columns.")
+public class CSVRecordSetWriter extends DateTimeTextRecordSetWriter
implements RecordSetWriterFactory {
+
+ private volatile CSVFormat csvFormat;
+
+ @Override
+ protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
+ final List<PropertyDescriptor> properties = new
ArrayList<>(super.getSupportedPropertyDescriptors());
+ properties.add(CSVUtils.CSV_FORMAT);
+ properties.add(CSVUtils.VALUE_SEPARATOR);
+ properties.add(CSVUtils.QUOTE_CHAR);
+ properties.add(CSVUtils.ESCAPE_CHAR);
+ properties.add(CSVUtils.COMMENT_MARKER);
+ properties.add(CSVUtils.NULL_STRING);
+ properties.add(CSVUtils.TRIM_FIELDS);
+ properties.add(CSVUtils.QUOTE_MODE);
+ properties.add(CSVUtils.RECORD_SEPARATOR);
+ properties.add(CSVUtils.TRAILING_DELIMITER);
+ return properties;
+ }
--- End diff --
Similar as before. This will be called at least 3 times, so may be static
initializer. This pattern appears in many places throughout this PR so consider
fixing it in many places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
