Github user scottyaslan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1659#discussion_r110667414
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-canvas-utils.js
---
@@ -412,9 +412,9 @@
// create object whose keys are the parameter name and the
values are the parameter values
var paramsObject = {};
- params.forEach(function (v, k) {
- paramsObject[k] = v;
- });
+ for(var pair of params.entries()) {
--- End diff --
Changing the "of" to "in" is not correct... I tried it and verified that
using the "in" breaks deep linking. If you look here (in the Browser
Compatibility section):
https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams we see that
"for...of" is the supported way to iterate over the GET params...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
