[ 
https://issues.apache.org/jira/browse/NIFI-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964952#comment-15964952
 ] 

ASF GitHub Bot commented on NIFI-3690:
--------------------------------------

GitHub user joewitt opened a pull request:

    https://github.com/apache/nifi/pull/1665

    NIFI-3690 updated L&N in nifi-gcp-nar and nifi-assembly and fixed nif…

    …i-gcp-processors to avoid jsr305 and json.org cat-x dependencies
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/joewitt/incubator-nifi NIFI-3690

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1665.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1665
    
----
commit cf879820c33bd6919abf7c734b786719760176d1
Author: joewitt <[email protected]>
Date:   2017-04-11T20:56:28Z

    NIFI-3690 updated L&N in nifi-gcp-nar and nifi-assembly and fixed 
nifi-gcp-processors to avoid jsr305 and json.org cat-x dependencies

----


> nifi-gcp-bundle contains undeclared (L&N) dependencies
> ------------------------------------------------------
>
>                 Key: NIFI-3690
>                 URL: https://issues.apache.org/jira/browse/NIFI-3690
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Joseph Witt
>            Assignee: Joseph Witt
>            Priority: Blocker
>             Fix For: 1.2.0
>
>
> [~gene-telligentdata] [~jameswing] In working NIFI-3089 I found the 
> nifi-gcp-nar. It contained a transitive dependency on org.json library which 
> is Category X for apache so must be removed.  I've got that address in 
> NIFI-3089 and will have a PR for that soon.  
> However, in looking at the L&N for the nar itself there are a ton of 
> dependencies in the nar and they're not referenced in the nar's L&N.  We must 
> resolve this before nifi-gcp-nar can be released w/NiFi.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to