[
https://issues.apache.org/jira/browse/NIFI-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967455#comment-15967455
]
ASF GitHub Bot commented on NIFI-3703:
--------------------------------------
GitHub user gresockj opened a pull request:
https://github.com/apache/nifi/pull/1671
NIFI-3703: Adding 'Allow Anonymous Credentials' property to AWS processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gresockj/nifi NIFI-3703
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1671.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1671
----
commit 12c1f52d008af07c81c8e995c96be1b474d5de8f
Author: Joe Gresock <[email protected]>
Date: 2017-04-13T11:32:27Z
NIFI-3703: Adding 'Allow Anonymous Credentials' property to AWS processors
----
> Allow AWS processors to use DefaultAWSCredentialsProviderChain
> --------------------------------------------------------------
>
> Key: NIFI-3703
> URL: https://issues.apache.org/jira/browse/NIFI-3703
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.1.1
> Reporter: Joseph Gresock
> Priority: Minor
>
> Currently, the AWS processors assume that credentials must always be provided
> to the AWS SDK constructors. When no credentials properties are specified,
> this causes AnonymousAWSCredentials to be used as a constructor argument to
> the AWS client. While this may be intended in some cases, we should also
> allow for the option of not passing in any credentials, which causes the
> client to use DefaultAWSCredentialsProviderChain.getInstance(), behaving as
> specified here:
> http://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/java-dg-roles.html
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
