Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1682#discussion_r112325468
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/serialization/SchemaRegistryRecordSetWriter.java
---
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.serialization;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.controller.ConfigurationContext;
+import
org.apache.nifi.schema.access.HortonworksEncodedSchemaReferenceWriter;
+import org.apache.nifi.schema.access.SchemaAccessWriter;
+import org.apache.nifi.schema.access.SchemaNameAsAttribute;
+import org.apache.nifi.schema.access.SchemaTextAsAttribute;
+
+public abstract class SchemaRegistryRecordSetWriter extends
SchemaRegistryService {
+
+ static final AllowableValue SCHEMA_NAME_ATTRIBUTE = new
AllowableValue("schema-name", "Use 'schema.name' Attribute",
+ "The FlowFile will be given an attribute named 'schema.name' and
this attribute will indicate the name of the schema in the Schema Registry.
Note that if"
+ + "the schema for a record is not obtained from a Schema
Registry, then no attribute will be added.");
+ static final AllowableValue AVRO_SCHEMA_ATTRIBUTE = new
AllowableValue("full-schema-attribute", "Use 'avro.schema' Attribute",
+ "The FlowFile will be given an attribute named 'avro.schema' and
this attribute will contain the Avro Schema that describes the records in the
FlowFile. "
+ + "The contents of the FlowFile need not be Avro, but the text
of the schema will be used.");
+ static final AllowableValue HWX_CONTENT_ENCODED_SCHEMA = new
AllowableValue("hwx-content-encoded-schema", "HWX Content-Encoded Schema
Reference",
--- End diff --
see my previous comments on this. I think we should avoid vendor specific
strategies unless we can strongly reference source material publishing the spec
we're talking about. Actually, given the simplicity of what we're describing I
think we should avoid vendor specifics entirely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
