Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1669#discussion_r112568901
  
    --- Diff: 
nifi-toolkit/nifi-toolkit-admin/src/test/groovy/org/apache/nifi/toolkit/admin/client/NiFiClientFactorySpec.groovy
 ---
    @@ -71,6 +93,71 @@ class NiFiClientFactorySpec extends Specification {
     
         }
     
    +    def "should verify CN in certificate based on subjectDN"(){
    --- End diff --
    
    I like these tests. If you add a test for the manipulated DN I posted 
above, you can verify that the `LdapName` implementation works with that. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to