[GitHub] nifi issue #1306: NIFI-1202: Site-to-Site batch settings.

[ijokarumawak]

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1306
  
    Hi @mcgilman,
    
    I've pushed another commit to incorporate your feedback.
    
    As for the default value rendering, I've used 'No value set' as shown below:
    
![image](https://cloud.githubusercontent.com/assets/1107620/25264584/f1a8f2b6-26a2-11e7-8a43-af0480bd425a.png)
    
    However, I didn't set a default value for batch duration, because users may 
want to limit batch by only flow file count or data size, for those use-cases, 
we shouldn't use duration to limit batch. If we specifies default value from UI 
layer, we will not be able to specify blank setting.
    
    Instead, I made the tooltip hint more clearly explain how those 
configuration affect to control batch. It works differently for input-port 
(client side throttle) and output-port (remote side throttle, client only ask 
its preference).
    
    For input port:
    
![image](https://cloud.githubusercontent.com/assets/1107620/25264659/4503f9c4-26a3-11e7-8bd1-e9d5903ec1cb.png)
    
    For output port:
    
![image](https://cloud.githubusercontent.com/assets/1107620/25264710/a578bcc2-26a3-11e7-8e48-14a9c16f65b8.png)
    
    Finally, for the partial update against DTO, I couldn't come up with better 
alternatives so I just updated API documentation. I hope it would be enough.
    
    
![image](https://cloud.githubusercontent.com/assets/1107620/25264734/cb674f16-26a3-11e7-90c0-5ffb9f720751.png)
    
    Please let me know if these updates address your concerns. Thanks again for 
your review comments!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---