[
https://issues.apache.org/jira/browse/NIFI-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985557#comment-15985557
]
ASF GitHub Bot commented on NIFI-3741:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1704
NIFI-3741: Improved connection error message for CaptureChangeMySQL
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-3741
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1704.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1704
----
----
> CaptureChangeMySQL should show actual IOException detail when it failed to
> connect
> ----------------------------------------------------------------------------------
>
> Key: NIFI-3741
> URL: https://issues.apache.org/jira/browse/NIFI-3741
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.2.0
> Reporter: Koji Kawamura
>
> When I setup a flow using CaptureChangeMySQL processor, I forgot to enable
> bin-log, and grant appropriate privileges at MySQL side, then
> CaptureChangeMySQL failed to connect the MySQL instance.
> However, it wan't easy for me to find what configuration I had missed. The
> error message that I got was "Could not connect binlog client to any of the
> specified hosts" without information of actual IOException. By debugging the
> source code, I finally recalled that extra configuration was needed for
> bin-log.
> [CaptureChangeMySQL.connect() |
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java#L665]
> does not log the Exception message and it may be difficult for users to
> diagnose what went wrong.
> It would be more user friendly if we add the message of the last thrown
> exception if it failed to connect to any. For instance, IOException message
> contains details like
> "com.github.shyiko.mysql.binlog.network.ServerException: Host '192.168.99.1'
> is not allowed to connect to this MySQL serve".
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
