Github user trixpan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1692#discussion_r113585955
  
    --- Diff: 
nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java
 ---
    @@ -110,24 +107,25 @@
         public static final PropertyDescriptor MATCHING_MODE = new 
PropertyDescriptor.Builder()
                 .name("MATCHING_MODE")
                 .displayName("Matching mode")
    -            .description("The ")
    +            .description("Defines if the Processor should try to match as 
many entries as possible (" + multiMatch.getDisplayName() +
    +                    ") or if it should stio after the first match (" + 
singleMatch.getDisplayName() + ")")
                 .required(true)
                 .allowableValues(singleMatch,multiMatch)
                 .defaultValue(singleMatch.getValue())
                 .build();
     
    -    public static final Relationship REL_MATCH = new Relationship.Builder()
    -            .name("Matched")
    +    public static final Relationship REL_FOUND = new Relationship.Builder()
    +            .name("found")
                 .description("Any FlowFile that is successfully matched to an 
existing hash will be sent to this Relationship.")
                 .build();
     
    -    public static final Relationship REL_NON_MATCH = new 
Relationship.Builder()
    -            .name("non-match")
    +    public static final Relationship REL_NOT_FOUND = new 
Relationship.Builder()
    +            .name("not found")
    --- End diff --
    
    sounds like good practice to me. Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to