Github user jdye64 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1597#discussion_r114116276
--- Diff:
nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/main/java/org/apache/nifi/websocket/jetty/JettyWebSocketClient.java
---
@@ -81,6 +87,16 @@
.defaultValue("3 sec")
.build();
+ public static final PropertyDescriptor SESSION_MAINTENANCE_INTERVAL =
new PropertyDescriptor.Builder()
+ .name("session-maintenance-interval")
+ .displayName("Session Maintenance Interval")
+ .description("The interval between session maintenance
activities.")
+ .required(true)
+ .expressionLanguageSupported(true)
+ .addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
+ .defaultValue("10 sec")
--- End diff --
Since this is invoking maintainSessions() and that is effectively
reconnecting sessions would it make sense to make this default value less than
the default value of CONNECTION_TIMEOUT just so by default this would prevent
connections from timing out at all? This would help in the case that the client
becomes inactive for longer than the default CONNECTION_TIMEOUT and help ensure
messages are not missed being delivered to the client.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
