[
https://issues.apache.org/jira/browse/NIFI-3670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990759#comment-15990759
]
ASF GitHub Bot commented on NIFI-3670:
--------------------------------------
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1720
NIFI-3670 - Expose the control of ListenSyslog's CLIENT_AUTH property…
… to DFM
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] ~~~Have you written or updated unit tests to verify your changes?~~~
- [X] ~~~If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?~~~
- [X] ~~~If applicable, have you updated the LICENSE file, including the
main LICENSE file under nifi-assembly?~~~
- [X] ~~~If applicable, have you updated the NOTICE file, including the
main NOTICE file found under nifi-assembly?~~~
- [X] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trixpan/nifi NIFI-3670
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1720.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1720
----
commit 6d7411d305bbaf3ecc87f8a795f4b114f4841f02
Author: Andre F de Miranda <[email protected]>
Date: 2017-05-01T12:32:51Z
NIFI-3670 - Expose the control of ListenSyslog's CLIENT_AUTH property to DFM
----
> ListenSyslog should expose a Client Auth property for TLS/SSL
> -------------------------------------------------------------
>
> Key: NIFI-3670
> URL: https://issues.apache.org/jira/browse/NIFI-3670
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.0.0, 1.1.0, 0.7.1, 1.1.1, 1.0.1
> Reporter: Bryan Bende
> Assignee: Andre F de Miranda
> Priority: Minor
>
> ListenSyslog currently hard codes the client auth to REQUIRED when creating
> an SSLContext:
> {code}
> sslContext =
> sslContextService.createSSLContext(SSLContextService.ClientAuth.REQUIRED);
> {code}
> It should expose a Client Auth property like ListenTCP does and use that:
> {code}
> public static final PropertyDescriptor CLIENT_AUTH = new
> PropertyDescriptor.Builder()
> .name("Client Auth")
> .description("The client authentication policy to use for the SSL
> Context. Only used if an SSL Context Service is provided.")
> .required(false)
> .allowableValues(SSLContextService.ClientAuth.values())
> .defaultValue(SSLContextService.ClientAuth.REQUIRED.name())
> .build();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
