Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1719#discussion_r114228274
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
---
@@ -106,10 +110,15 @@ public void onTrigger(final ProcessContext context,
final ProcessSession session
final long transferMillis =
TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startNanos);
session.getProvenanceReporter().send(flowFile,
blob.getSnapshotQualifiedUri().toString(), transferMillis);
- } catch (IllegalArgumentException | URISyntaxException |
StorageException e) {
- getLogger().error("Failed to put Azure blob {}", new
Object[]{blobPath}, e);
- flowFile = session.penalize(flowFile);
- session.transfer(flowFile, REL_FAILURE);
+ } catch (IllegalArgumentException | URISyntaxException |
StorageException | ProcessException e) {
+ if (e instanceof ProcessException && storedException.get() ==
null) {
+ throw (ProcessException) e;
+ } else {
+ Exception failureException =
Optional.ofNullable(storedException.get()).map(x -> x).orElse(e);
--- End diff --
@jtstorck I don't think you need the .map() here. It looks like orElse()
will already give you the value if the optional is absent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
