[
https://issues.apache.org/jira/browse/NIFI-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993176#comment-15993176
]
ASF GitHub Bot commented on NIFI-3771:
--------------------------------------
GitHub user jfrazee opened a pull request:
https://github.com/apache/nifi/pull/1731
NIFI-3771 Move HL7 test docs into class members to avoid git rewriting CRs
See also [NIFI-1655](https://issues.apache.org/jira/browse/NIFI-1655) and
#1696
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jfrazee/nifi NIFI-3771
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1731.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1731
----
commit e5a89b1145f9c5a47bc53c0b6626ced2dad85069
Author: Joey Frazee <[email protected]>
Date: 2017-05-02T15:48:10Z
NIFI-3771 Move HL7 test docs into class members to avoid git rewriting CRs
----
> Move HL7 test docs into class members to avoid git rewriting CRs
> ----------------------------------------------------------------
>
> Key: NIFI-3771
> URL: https://issues.apache.org/jira/browse/NIFI-3771
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joey Frazee
> Assignee: Joey Frazee
>
> HL7 makes strict assumptions on the use of CR for segment separators. Because
> of this there have been occasional test failures due to developer
> environments, patch/diff formatting or git rewriting. We should just move the
> contents of
> ./nifi-commons/nifi-hl7-query-language/src/test/resources/{hyperglycemia,
> hypoglycemia} into Strings in the TestHL7Query test class.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
