Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114367613
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -88,10 +102,17 @@ class YamlConfiguration : public FlowConfiguration {
void parseRemoteProcessGroupYaml(YAML::Node *node,
core::ProcessGroup * parent);
// Process Provenance Report YAML
- void parseProvenanceReportingYaml(YAML::Node *reportNode,
core::ProcessGroup * parentGroup);
+ void parseProvenanceReportingYaml(YAML::Node *reportNode,
+ core::ProcessGroup * parentGroup);
// Parse Properties Node YAML for a processor
void parsePropertiesNodeYaml(YAML::Node *propertiesNode,
std::shared_ptr<core::Processor> processor);
+ // Helper function to get or generate a component's id field
--- End diff --
I like that. I'll update all existing function comments in
YamlConfiguration.h while I'm here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
