[
https://issues.apache.org/jira/browse/NIFI-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993334#comment-15993334
]
ASF GitHub Bot commented on NIFI-2752:
--------------------------------------
GitHub user jskora opened a pull request:
https://github.com/apache/nifi/pull/1732
NIFI-2752 Correct ReplaceText default pattern and unit tests (0.x)
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jskora/nifi NIFI-2752-0.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1732.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1732
----
commit 64e8e00152dc53114aac53ad67d3c241836b5784
Author: Joe Skora <[email protected]>
Date: 2017-05-02T17:14:28Z
NIFI-2752 Correct ReplaceText default pattern and unit tests (0.x)
----
> Correct ReplaceText default pattern and unit tests
> --------------------------------------------------
>
> Key: NIFI-2752
> URL: https://issues.apache.org/jira/browse/NIFI-2752
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.1.0, 0.8.0, 0.7.1
> Reporter: Joe Skora
> Assignee: Joe Skora
> Fix For: 1.1.0
>
>
> [{{ReplaceText.DEFAULT_REGEX}}|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java#L87]
> is defined as "(?s:\^.\*$)", which is valid PCRE but must be expressed as
> "(?s)(\^.\*$)" in Java.
> The Java [Pattern class|https://docs.oracle.com/javase/8/docs/api/index.html]
> specifies that patterns like "(?idmsux-idmsux:X)" are _non-capturing_, so
> anything but the default pattern and replacement value result in empty
> output. This isn't caught by unit tests because the code short circuits if
> the default pattern and replacement are found in
> [ReplaceText.onTrigger()|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java#L217].
> This hides the capture group problem from the unit tests and the default
> processor configuration, but causes the processor to produce empty output if
> using non-trivial patterns and replacements.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
