Github user benqiu2016 commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/90#discussion_r114679611
  
    --- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
    @@ -450,27 +436,24 @@ void YamlConfiguration::parseConnectionYaml(
                 } else {
                   // we ran out of ways to discover the source processor
                   logger_->log_error(
    -                  "Could not locate a source with name %s to create a 
connection",
    -                  connectionSrcProcName);
    +                  "Could not locate a source with name %s to create a 
connection", connectionSrcProcName);
                   throw std::invalid_argument(
    -                  "Could not locate a source with name " +
    -                      connectionSrcProcName + " to create a connection ");
    +                  "Could not locate a source with name " + 
connectionSrcProcName + " to create a connection ");
                 }
               }
             }
             connection->setSourceUUID(srcUUID);
     
             // Configure connection destination
             uuid_t destUUID;
    -        std::string connectionDestProcName = connectionNode["destination 
name"]
    -            .as<std::string>();
             if (connectionNode["destination id"]) {
    -          std::string connectionDestProcId = connectionNode["destination 
id"]
    -              .as<std::string>();
    +          std::string connectionDestProcId = connectionNode["destination 
id"].as<std::string>();
               uuid_parse(connectionDestProcId.c_str(), destUUID);
             } else {
               // we use the same logic as above for resolving the source 
processor
               // for looking up the destination processor in absence of a 
processor id
    +          checkRequiredField(&connectionNode, "destination name", 
CONFIG_YAML_CONNECTIONS_KEY);
    --- End diff --
    
    same as above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to