[
https://issues.apache.org/jira/browse/NIFI-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996056#comment-15996056
]
ASF GitHub Bot commented on NIFI-3793:
--------------------------------------
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1748#discussion_r114690849
--- Diff: nifi-toolkit/nifi-toolkit-admin/pom.xml ---
@@ -46,7 +46,7 @@ language governing permissions and limitations under the
License. -->
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-client-dto</artifactId>
- <version>${client.version}</version>
+ <version>${project.version}</version>
--- End diff --
I would recommend avoiding these variables here and instead just use
'1.2.0-SNAPSHOT'. The former has proven problematic during the release process
and the latter has proven highly reliable and gets automatically updated by the
versions plugin during the release process.
> nifi-toolkit-admin uses client.version of 1.2.0-SNAPSHOT
> --------------------------------------------------------
>
> Key: NIFI-3793
> URL: https://issues.apache.org/jira/browse/NIFI-3793
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Bryan Bende
> Assignee: Yolanda M. Davis
> Priority: Blocker
> Fix For: 1.2.0
>
>
> The nifi-toolkit pom declares client.version which is currently set to
> 1.2.0-SNAPSHOT, and then nifi-toolkit-admin has a dependency on
> nifi-client-dto using client.version.
> The problem is that the release plugin will not automatically update
> client.version and then if you build with a clean Maven repo (or someone who
> never built master while at 1.2.0-SNAPSHOT) you get a failure:
> nifi-toolkit-admin: Could not resolve dependencies for project
> org.apache.nifi:nifi-toolkit-admin:jar:1.2.0: The following artifacts could
> not be resolved: org.apache.nifi:nifi-client-dto:jar:1.2.0-SNAPSHOT,
> org.apache.nifi:nifi-web-security:jar:1.2.0-SNAPSHOT: Failure to find
> org.apache.nifi:nifi-client-dto:jar:1.2.0-SNAPSHOT
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
