Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114792714
--- Diff: libminifi/src/io/ClientSocket.cpp ---
@@ -39,7 +40,7 @@ namespace io {
char *Socket::HOSTNAME =
const_cast<char*>(Socket::getMyHostName(0).c_str());
-Socket::Socket(const std::string &hostname, const uint16_t port,
+Socket::Socket(std::shared_ptr<SocketContext> context, const std::string
&hostname, const uint16_t port,
--- End diff --
same, may want to pass by const reference here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
