[
https://issues.apache.org/jira/browse/NIFI-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996920#comment-15996920
]
ASF GitHub Bot commented on NIFI-3788:
--------------------------------------
GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/1753
NIFI-3788 Switched Amazon HTTP client instantiation from using null H…
…ostnameVerifier (which defaulted to Strict, which cannot handle wildcard
certificate hostnames) to `DefaultHostnameVerifier`, which is fine.
I still want to add unit tests and integration tests, but I ran a flow
which had previously caused the reproducible exception and this worked fine
(flow showed objects were put in S3, no exceptions, and I verified through AWS
Web Console that new objects were present).
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-3788
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1753.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1753
----
commit 9dd0fcfb96d6b32f89c380f76e670f63f4ec9371
Author: Andy LoPresto <[email protected]>
Date: 2017-05-03T23:02:04Z
NIFI-3788 Switched Amazon HTTP client instantiation from using null
HostnameVerifier (which defaulted to Strict, which cannot handle wildcard
certificate hostnames) to DefaultHostnameVerifier, which is fine.
I still want to add unit tests and integration tests, but I ran a flow
which had previously caused the reproducible exception and this worked fine
(flow showed objects were put in S3, no exceptions, and I verified through AWS
Web Console that new objects were present).
----
> Support wildcard certificates in SSLStandardContextService
> ----------------------------------------------------------
>
> Key: NIFI-3788
> URL: https://issues.apache.org/jira/browse/NIFI-3788
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.1.1
> Reporter: Andy LoPresto
> Assignee: Andy LoPresto
> Labels: certificate, pki, security, tls
>
> Some users have reported issues when attempting to connect to an external
> service which is secured for TLS via a wildcard certificate (i.e. hostname is
> {{https://example.domain.com}} and the certificate DN contains
> {{CN=*.domain.com}}. This requires changes in the
> {{SSLStandardContextService}} to correctly parse the CN and evaluate wildcard
> entries if present.
> In addition, as specified by [RFC 2818|https://tools.ietf.org/html/rfc2818],
> certificate evaluation (specifically hostname validation) should prioritize
> Subject Alternative Names over DN parsing. Chrome 58+ has begun to implement
> this prioritization, which can cause issues with certificate validation even
> if the CN matches the hostname but SANs are present but do not include the
> hostname.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
