[
https://issues.apache.org/jira/browse/NIFI-3825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999046#comment-15999046
]
ASF GitHub Bot commented on NIFI-3825:
--------------------------------------
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/1765
NIFI-3825 fix L&N for jolt, json, and source deps
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-3825
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1765.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1765
----
commit e5bb0d80dc770bf59076f0ee26ac5a1a9387cf44
Author: joewitt <[email protected]>
Date: 2017-05-05T22:16:00Z
NIFI-3825 fix L&N for jolt, json, and source deps
----
> Fix L&N for open json and jolt references
> -----------------------------------------
>
> Key: NIFI-3825
> URL: https://issues.apache.org/jira/browse/NIFI-3825
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Affects Versions: 1.2.0
> Reporter: Joseph Witt
> Assignee: Joseph Witt
> Priority: Critical
> Fix For: 1.2.0
>
>
> TDUNNING open-json is in at least nifi-gcp-nar and nifi-assembly. Must be in
> both NOTICE files. Needs an entry for it as ASLv2 and its copyright. As
> found here: https://github.com/tdunning/open-json/tree/json-1.8
> +++
> Android JSON library
> Copyright (C) 2010 The Android Open Source Project
> This product includes software developed by
> The Android Open Source Project
> JOLT L&N needs to be improved.
> - It is found in the nifi-standard-nar LICENSE file despite being an ASLv2
> item. It is already properly in the NOTICE so just needs removal from
> LICENSE.
> - It is found in the nifi-jolt-transform-json-ui in LICENSE. Is already in
> NOTICE properly so just needs removal from LICENSE.
> - We have an apparent source dependency from reading the NOTICE but might
> have an incorrect header and/or we need to carry that to the top level notice
> as well.
> standard-bundle-nar has source reference to elastic but it is not in top
> level notice
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
