[
https://issues.apache.org/jira/browse/NIFI-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999139#comment-15999139
]
ASF GitHub Bot commented on NIFI-3826:
--------------------------------------
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/1766
NIFI-3826 added proper NOTICE entries for apache calcite and maxmind …
…source
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-3826
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1766.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1766
----
commit 3ed356a5b88d921a02d3cbdeb2119f1a03a67532
Author: joewitt <[email protected]>
Date: 2017-05-05T23:44:20Z
NIFI-3826 added proper NOTICE entries for apache calcite and maxmind source
----
> Correct L&N references for use of Apache Calcite and Maxmind sources
> --------------------------------------------------------------------
>
> Key: NIFI-3826
> URL: https://issues.apache.org/jira/browse/NIFI-3826
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Reporter: Joseph Witt
> Priority: Critical
> Fix For: 1.2.0
>
>
> Our code in
> nifi/nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/TestGeoEnrichIP.java
> includes several test response lines from
> https://github.com/maxmind/GeoIP2-java/blob/v2.2.0/src/test/java/com/maxmind/geoip2/TestTransport.java
> For this I'll cite the code properly in our top level NOTICE.
>
> FlowFileProjectTableScanRule comes from calcite CSVProjecTableScanRule
> FlowFileTableScan comes from calcite CSVTableScan
> For both of these I'll add a NOTICE entry in our L&N both top level and
> within the nar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
