GitHub user kevdoran opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/95
MINIFI-290 Refactor Tests
Changes include:
- Moving libminifi test resources to test/resources
- Setting working directory when adding tests to ctest
so that tests can be loaded using a relative path
- Moved YAML config test strings to test resources
- Minor error log message correction noticed during testing
- Tweak to ubuntu Dockerfile to fix docker build target
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevdoran/nifi-minifi-cpp
MINIFI-290-test-resource-files
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/95.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #95
----
commit eef2e65c0cfa7a0245f1e23b79b1ada001261dda
Author: Kevin Doran <[email protected]>
Date: 2017-05-08T22:25:17Z
MINIFI-290 Refactor Tests
Changes include:
- Moving libminifi test resources to test/resources
- Setting working directory when adding tests to ctest
so that tests can be loaded using a relative path
- Moved YAML config test strings to test resources
- Minor error log message correction noticed during testing
- Tweak to ubuntu Dockerfile to fix docker build target
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
