[
https://issues.apache.org/jira/browse/NIFI-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001964#comment-16001964
]
ASF GitHub Bot commented on NIFI-3832:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1768
NIFI-3832: Fixed AvroRecordSetWriter validation NPE.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes? No,
tested it manually.
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-3832
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1768.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1768
----
commit b4dec3f02ea08122e05d4472cf6f246500e13b02
Author: Koji Kawamura <[email protected]>
Date: 2017-05-09T03:13:19Z
NIFI-3832: Fixed AvroRecordSetWriter validation NPE.
----
> AvroRecordSetWriter initial validation fails with NullPointerException
> ----------------------------------------------------------------------
>
> Key: NIFI-3832
> URL: https://issues.apache.org/jira/browse/NIFI-3832
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.2.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
> Priority: Minor
>
> AvroRecordSetWriter overrides default value for SCHEMA_WRITE_STRATEGY to
> AVRO_EMBEDDED. However getRequiredSchemaFields uses SCHEMA_WRITE_STRATEGY
> constant defined in its super class to get value, which has
> SCHAMA_NAME_ATTRIBUTE as its default value.
> So, at the initial validation (before user hit apply button), following code
> go through the if statement and results in NPE:
> {code}
> @Override
> protected Set<SchemaField> getRequiredSchemaFields(final
> ValidationContext validationContext) {
> final String writeStrategyValue =
> validationContext.getProperty(SCHEMA_WRITE_STRATEGY).getValue();
> if (writeStrategyValue.equalsIgnoreCase(AVRO_EMBEDDED.getValue())) {
> return requiredSchemaFields;
> }
> return super.getRequiredSchemaFields(validationContext);
> }
> {code}
> Here is the stacktrace:
> {code}
> 2017-05-08 19:19:22,749 ERROR [NiFi Web Server-158]
> o.a.n.c.AbstractConfiguredComponent Failed to perform validation of
> AvroRecordSetWriter[id=e78aac25-015b-1000-f931-33bf517d5e42]
> java.lang.NullPointerException: null
> at
> org.apache.nifi.serialization.SchemaRegistryRecordSetWriter.getRequiredSchemaFields(SchemaRegistryRecordSetWriter.java:138)
> at
> org.apache.nifi.avro.AvroRecordSetWriter.getRequiredSchemaFields(AvroRecordSetWriter.java:138)
> at
> org.apache.nifi.serialization.SchemaRegistryRecordSetWriter.customValidate(SchemaRegistryRecordSetWriter.java:147)
> at
> org.apache.nifi.components.AbstractConfigurableComponent.validate(AbstractConfigurableComponent.java:126)
> at
> org.apache.nifi.controller.AbstractConfiguredComponent.getValidationErrors(AbstractConfiguredComponent.java:460)
> at
> org.apache.nifi.controller.service.StandardControllerServiceNode.getValidationErrors(StandardControllerServiceNode.java:506)
> at
> org.apache.nifi.controller.AbstractConfiguredComponent.getValidationErrors(AbstractConfiguredComponent.java:448)
> at
> org.apache.nifi.web.api.dto.DtoFactory.createControllerServiceDto(DtoFactory.java:1381)
> at
> org.apache.nifi.web.StandardNiFiServiceFacade.createControllerServiceEntity(StandardNiFiServiceFacade.java:30
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
