[ 
https://issues.apache.org/jira/browse/NIFI-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008433#comment-16008433
 ] 

ASF GitHub Bot commented on NIFI-3881:
--------------------------------------

GitHub user tequalsme opened a pull request:

    https://github.com/apache/nifi/pull/1791

    NIFI-3881 Fix PutHiveStreaming EL evaluation

    2 properties in PutHiveStreaming (`TXNS_PER_BATCH` and `RECORDS_PER_TXN`) 
are marked as supporting expression language, but not evaluating it. Every unit 
test is unnecessarily marked with 
`TestRunner.setValidateExpressionUsage(false)` which effectively hides the bug.
    
    The PR adds calls to `evaluateAttributeExpressions()` where each property 
is accessed, and removes the unnecessary disabling in the unit tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tequalsme/nifi nifi-3881

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1791.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1791
    
----
commit addb2a5cb81c9b8c53fdd7d32a1c00ff2c5d313c
Author: Tim Reardon <[email protected]>
Date:   2017-05-12T17:25:24Z

    NIFI-3881 Fix PutHiveStreaming EL evaluation

----


> PutHiveStreaming properties not properly evaluating EL
> ------------------------------------------------------
>
>                 Key: NIFI-3881
>                 URL: https://issues.apache.org/jira/browse/NIFI-3881
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Tim Reardon
>            Priority: Minor
>
> 2 properties in PutHiveStreaming (TXNS_PER_BATCH and RECORDS_PER_TXN) are 
> marked as supporting expression language, but not evaluating it. Every unit 
> test is unnecessarily marked with 
> TestRunner.setValidateExpressionUsage(false) which effectively hides the bug.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to