[
https://issues.apache.org/jira/browse/NIFI-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008453#comment-16008453
]
ASF GitHub Bot commented on NIFI-3879:
--------------------------------------
GitHub user champagst opened a pull request:
https://github.com/apache/nifi/pull/1792
NIFI-3879: Allow null Avro default values
- Avro uses their own class for null values, so a standard check against
null isn't picking them up.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/champagst/nifi NIFI-3879
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1792.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1792
----
commit e781941871fa83d4802c5f3b0a60aedc69e27e94
Author: Steve Champagne <[email protected]>
Date: 2017-05-12T17:32:14Z
NIFI-3879: Allow null Avro default values
- Avro uses their own class for null values, so a standard check against
null isn't picking them up.
----
> Null Avro Values
> ----------------
>
> Key: NIFI-3879
> URL: https://issues.apache.org/jira/browse/NIFI-3879
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Steve Champagne
> Attachments: NullableField.xml
>
>
> I'm getting an error from the convertRecord processor saying an Avro Schema
> couldn't be found. I've narrowed it down to the processor thinking that my
> schema is invalid. Would it be possible to change the log message to say when
> the schema is invalid instead?
> In my schema I have a field that is optional, so I'm using a null default.
> This is what the processor thinks is invalid about it. I tried the same
> schema using the Java avro library and it seems like it's valid.
> I've attached an example template and here's the java code I'm using.
> {code:java}
> Schema schema = new
> Schema.Parser().parse("{\"type\":\"record\",\"name\":\"Test\",\"fields\":[{\"name\":\"name\",\"type\":\"string\"},{\"name\":\"deleted\",\"type\":[\"null\",\"boolean\"],\"default\":null}]}");
> GenericRecord t1 = new GenericData.Record(schema);
> t1.put("name", "Bob");
> ByteArrayOutputStream out = new ByteArrayOutputStream();
> DatumWriter<GenericRecord> datumWriter = new
> GenericDatumWriter<GenericRecord>(schema);
> DataFileWriter<GenericRecord> dataFileWriter = new
> DataFileWriter<GenericRecord>(datumWriter);
> dataFileWriter.create(schema, out);
> dataFileWriter.append(t1);
> dataFileWriter.close();
> System.out.println(new String(out.toByteArray()));
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
