[
https://issues.apache.org/jira/browse/NIFI-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009932#comment-16009932
]
ASF GitHub Bot commented on NIFI-3895:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1797
NIFI-3895: Fixed AvroReader to use Schema Access Strategy default val…
…ue properly.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-3895
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1797.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1797
----
commit fe721e56fc9a15fef30fff547093fe6fb5ca3db4
Author: Koji Kawamura <[email protected]>
Date: 2017-05-15T02:26:30Z
NIFI-3895: Fixed AvroReader to use Schema Access Strategy default value
properly.
----
> AvroReader 'Schema Access Strategy' defaults to 'Use Embedded Avro Schema'
> but it doesn't use embedded schema by default
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-3895
> URL: https://issues.apache.org/jira/browse/NIFI-3895
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.2.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
>
> Similar to NIFI-3832, AvroReader uses a PropertyDescriptor defined at
> SchemaAccessUtil.SCHEMA_ACCESS_STRATEGY which doesn't have a customized
> default value.
> So, AvroReader shows 'Use Embedded Avro Schema' for 'Schema Access Strategy'
> by default, but it actually uses 'Use 'Schema Name' Property'.
> This can be problematic with following flow:
> {code}
> ExecuteSQL -> ConvertRecord (Avro/JSON)
> {code}
> Where ExecuteSQL generates FlowFiles containing embedded Avro schema, but
> AvroReader doesn't utilize it with initial setting.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
