[
https://issues.apache.org/jira/browse/NIFI-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010691#comment-16010691
]
ASF GitHub Bot commented on NIFI-3681:
--------------------------------------
GitHub user josephxsxn opened a pull request:
https://github.com/apache/nifi/pull/1800
NIFI-3681 - Controller Service for Processor Leader Elections
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
-- Looking for feedback on this implementation before squashing into a
single commit for merge. Any feedback is welcome. I have done some testing with
the current build on a 3 node cluster and it works very well in terms of
keeping leader etc. @Xsixteen @GrayGwizdz can you guys take a read over this
before the real commiters comment?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/josephxsxn/nifi NIFI-3681
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1800.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1800
----
commit ef32b7ea537056f2f8129b5e61f3ef7cb5247a08
Author: telore <[email protected]>
Date: 2017-05-10T01:26:46Z
some inital integration NIFI-3681
commit 1a89620664b08036812f84231c4190b762a05c4f
Author: telore <[email protected]>
Date: 2017-05-11T00:48:42Z
some more changes
commit a5db25374bd3f4aed01e55b88e75ea8f37f97bd8
Author: telore <[email protected]>
Date: 2017-05-12T00:30:27Z
checkstyle and tests
commit ca0eb8e3c79d7d4f4068083e9d0732e34d343a9c
Author: telore <[email protected]>
Date: 2017-05-12T01:23:40Z
resources fixed
commit af5b3dbb78f59083331ca1affc28311006c452e6
Author: telore <[email protected]>
Date: 2017-05-14T13:31:34Z
fixed path validator
commit c906cb2110096eeee3b125f88b4b1cd42760b7e0
Author: telore <[email protected]>
Date: 2017-05-14T15:34:13Z
shutdown logic
commit 32587851660be8e397e509440767816fd7cee8e4
Author: telore <[email protected]>
Date: 2017-05-14T18:43:36Z
withstands restart
commit abf4efbf85ba307f251d6042668f2506c3e5aa21
Author: telore <[email protected]>
Date: 2017-05-14T19:55:07Z
changes
commit c7f71299e4efc2400f9419088f18a0cbd0e44bc8
Author: telore <[email protected]>
Date: 2017-05-15T10:42:08Z
some changes for connection loss
commit 2c63d3a4dc415adae69311af327ebb8241bc3914
Author: worker <[email protected]>
Date: 2017-05-15T14:53:31Z
changes
commit dffd4ea7df3d06a3989e997112adac38d7cffe39
Author: worker <[email protected]>
Date: 2017-05-15T14:56:10Z
Merge branch 'master' into NIFI-3681
----
> Controller Service for Processor Leader Elections
> --------------------------------------------------
>
> Key: NIFI-3681
> URL: https://issues.apache.org/jira/browse/NIFI-3681
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joseph Niemiec
> Assignee: Joseph Niemiec
>
> Today I find a need for NiFi Cluster to allow a specific set of processors to
> perform a 'LeaderElection' of sorts to allow for a single processor to
> update the process shared cluster state with assignments (both initial and
> recovery.) The CS would be responsible for joining a Zookeeper group, the
> logic itself, performing new elections should an leader die, etc...
> At its core I envision a simple API provided by the CS
> * String - whoIsLeader
> * List[String] - aliveElectors
> * Long- LastElectionEpoch ? - Not sure about this, but would it be good to
> detect if an election occurred and the leader did not change but the election
> occured. Maybe a UUID-4?
> While thinking ZK is best as Clustered NiFi already requires it would there
> be value in implementing a standalone RAFT or PAXOS that runs at the cluster
> level?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
