Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/83#discussion_r116893221
  
    --- Diff: libminifi/test/resources/TestControllerServices.yml ---
    @@ -0,0 +1,62 @@
    +Flow Controller:
    --- End diff --
    
    Can't leave comments on binary items so I am annotating on the nearest 
neighbor.  Noticed that libminifi/test/libminifi.a seems to have crept its way 
into the commit.  Could we update .gitignore to cover the new structure as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to