Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1820
  
    For future reference...
    
    There are 4 places that uses Inflater/Deflater at S2S client and server:
    
    1. S2S Client receives data from remote output-port: **NOT** calling 
inflator.end explicitly (added by previous PR but removed by new PR)
    2. S2S Client sends data to remote input-port: Calls deflator.end
    3. S2S Server receives data through input-port: Calls inflator.end (fixed 
consume stream and inflator.end by new PR)
    4. S2S Server sends data through output-port: Calls deflator.end
    
    Ideally we should call Inflater/Deflater.end as often as possible, however 
DataPacket which is holding the inputStream is exposed to S2S clients and we 
can't safely close the inflater since we don't know when the stream is 
consumed, we can't call inflator.end for the case.1 in above list. But even if 
we don't call inflater/deflater.end explicitly, when JVM finalizes it, it will 
be cleared.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to