[
https://issues.apache.org/jira/browse/NIFI-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015962#comment-16015962
]
ASF GitHub Bot commented on NIFI-3935:
--------------------------------------
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/1823
NIFI-3935 made the old persistent prov test more forgiving of timing …
…issues and extended lucene test timeouts for slower environments. These
should be integration tests really.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-3935
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1823
----
commit 6220e8f1a79aab62bcc39990d771bd2880e8e184
Author: joewitt <[email protected]>
Date: 2017-05-18T15:43:46Z
NIFI-3935 made the old persistent prov test more forgiving of timing issues
and extended lucene test timeouts for slower environments. These should be
integration tests really.
----
> TestPersistentProvenanceRepository frequently fails in travis / likely slow
> machine timing bug in test
> ------------------------------------------------------------------------------------------------------
>
> Key: NIFI-3935
> URL: https://issues.apache.org/jira/browse/NIFI-3935
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Joseph Witt
> Assignee: Joseph Witt
>
> {quote}
> Tests run: 35, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 99.013 sec
> <<< FAILURE! - in
> org.apache.nifi.provenance.TestPersistentProvenanceRepository
> testAddAndRecover(org.apache.nifi.provenance.TestPersistentProvenanceRepository)
> Time elapsed: 3.646 sec <<< FAILURE!
> java.lang.AssertionError: expected:<10> but was:<9>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.nifi.provenance.TestPersistentProvenanceRepository.testAddAndRecover(TestPersistentProvenanceRepository.java:396)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
