[
https://issues.apache.org/jira/browse/NIFI-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018028#comment-16018028
]
ASF GitHub Bot commented on NIFI-3946:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1833
NIFI-3946: Update LookupService to take a Map instead of a String for…
… the input
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3946
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1833.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1833
----
commit d981ac0ea6f45290459122a696457555a1cc3c8a
Author: Mark Payne <[email protected]>
Date: 2017-05-19T20:42:51Z
NIFI-3946: Update LookupService to take a Map instead of a String for the
input
----
> Should update LookupRecord to allow multi criteria lookups
> ----------------------------------------------------------
>
> Key: NIFI-3946
> URL: https://issues.apache.org/jira/browse/NIFI-3946
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Joseph Witt
> Assignee: Mark Payne
>
> At present the LookupRecord processor allows a single criteria lookup.
> We need to provide a lookup API which takes a map of string key/values that a
> given lookup can use when searching for the result. The LookupRecord
> processor should change such that all dynamic properties are the loookup key
> names with values that are the RecordPath to find the value for that given
> key. The resulting map would be passed to the lookup service. Also the lookup
> service API should allow returning the set of required key names so that the
> processor can validate once all required keys have RecordPaths to search for
> values.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
