[
https://issues.apache.org/jira/browse/NIFI-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018215#comment-16018215
]
ASF GitHub Bot commented on NIFI-3948:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1834
NIFI-3948: Added flush() method to RecordWriter and call it when writ…
…ing a single record to OutputStream for PublishKafkaRecord. Also removed
no-longer-used class WriteAvroResult
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3948
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1834.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1834
----
commit 3cf91443e4be321b0f48def47ab4c63ed0145c73
Author: Mark Payne <[email protected]>
Date: 2017-05-20T00:52:26Z
NIFI-3948: Added flush() method to RecordWriter and call it when writing a
single record to OutputStream for PublishKafkaRecord. Also removed
no-longer-used class WriteAvroResult
----
> PublishKafkaRecord_0_10 appears to no longer write messages on correct
> boundaries
> ---------------------------------------------------------------------------------
>
> Key: NIFI-3948
> URL: https://issues.apache.org/jira/browse/NIFI-3948
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.3.0
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Critical
> Fix For: 1.3.0
>
>
> This issue appears only to be a problem on master and does not affect
> previously released version of Apache NiFi. I am trying to send messages to
> Kafka using PublishKafkaRecord_0_10 with the JSON Writer. The messages appear
> not to be demarcated properly and have data missing.
> It appears to be due to the JSON Writer needing to flush its output before
> creating the byte[] that we push to Kafka.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
