Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1830#discussion_r117677184
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/SimpleKeyValueLookupService.java
 ---
    @@ -41,7 +48,9 @@ protected PropertyDescriptor 
getSupportedDynamicPropertyDescriptor(final String
                 .name(propertyDescriptorName)
                 .required(false)
                 .dynamic(true)
    -            .addValidator(Validator.VALID)
    +            
.addValidator(StandardValidators.createAttributeExpressionLanguageValidator(AttributeExpression.ResultType.STRING,
 true))
    +            
.addValidator(StandardValidators.ATTRIBUTE_KEY_PROPERTY_NAME_VALIDATOR)
    --- End diff --
    
    I think we can remove ATTRIBUTE_KEY_PROPERTY_NAME_VALIDATOR. The dynamic 
properties of this processor are not representing FlowFile attribute names. It 
is a little bit misleading.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to