Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1833#discussion_r117738594
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/maxmind/IPLookupService.java
---
@@ -146,17 +153,27 @@ public void closeReader() throws IOException {
}
@Override
- public Optional<Record> lookup(final String key) throws
LookupFailureException {
- if (key == null) {
+ public Set<String> getRequiredKeys() {
+ return REQUIRED_KEYS;
+ }
+
+ @Override
+ public Optional<Record> lookup(final Map<String, String> coordinates)
throws LookupFailureException {
+ if (coordinates == null) {
return Optional.empty();
}
+ final String ipAddress = coordinates.get(IP_KEY);
+ if (ipAddress == null) {
+ return null;
--- End diff --
Yes, definitely. Good catch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
