[
https://issues.apache.org/jira/browse/NIFI-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020093#comment-16020093
]
ASF GitHub Bot commented on NIFI-3949:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1839
NIFI-3949: Updated Grok Reader to allow for sub-patterns to be used w…
…hen determining the schema
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3949
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1839.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1839
----
commit 83ec7e979522a6932f46839edf2bca0969ebf817
Author: Mark Payne <[email protected]>
Date: 2017-05-22T20:04:34Z
NIFI-3949: Updated Grok Reader to allow for sub-patterns to be used when
determining the schema
----
> NullPointerException from GrokReader
> ------------------------------------
>
> Key: NIFI-3949
> URL: https://issues.apache.org/jira/browse/NIFI-3949
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Bryan Bende
> Priority: Minor
>
> When creating a GrokReader, I specified an expression of:
> %\{SYSLOGBASE\}%\{GREEDYDATA:message\}
> And I left the default schema strategy of "use fields from grok expression".
> This resulted in an NPE:
> {code}
> java.lang.NullPointerException: null
> at java.util.Objects.requireNonNull(Objects.java:203)
> at
> org.apache.nifi.serialization.record.RecordField.<init>(RecordField.java:50)
> at
> org.apache.nifi.serialization.record.RecordField.<init>(RecordField.java:33)
> at
> org.apache.nifi.grok.GrokReader.createRecordSchema(GrokReader.java:150)
> at org.apache.nifi.grok.GrokReader.preCompile(GrokReader.java:136)
> {code}
> This appears to be because I didn't specify a name for SYSLOGBASE, since I
> was expecting it to see what SYSLOGBASE expands to and then use and named
> fields under that. If we don't want to support that expansion, then we should
> at least validate that all parts of the Grok expression have a name.
> Next I changed to using a schema defined in an AvroSchemaRegistry and
> referencing it by name, but I still got the above exception because the
> preCompile method always attempts to create a RecordSchema from the
> GrokExpression, even if you selected a different strategy.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
