Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1838#discussion_r117835377
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/coordination/heartbeat/HeartbeatMonitor.java
---
@@ -59,6 +59,13 @@
void purgeHeartbeats();
/**
+ * Returns when the heartbeats were purged last.
+ *
+ * @return when the heartbeats were purged last
+ */
+ long getPurgeTimestamp();
--- End diff --
This feels a bit odd to add to HeartbeatMonitor. I think this is a function
of the specific implementation of AbstractHeartbeatMonitor. I think this should
instead be an abstract method on the AbstractHeartbeatMonitor instead of going
into this interface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
